remove invalid expectations for dd, dt, associationlist, associationlistkey, associationlistvalue #47608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istkey, associationlistvalue
wpt-pr-bot
requested review from
jnurthen,
MelSumner,
scottaohara and
spectranaut
This was referenced Aug 15, 2024
cookiecrook
commented
Aug 15, 2024
|
@aleventhal - can you take a look? |
cookiecrook
commented
Aug 15, 2024
accname/name/comp_label.html
Outdated
| <dl aria-label="label" data-expectedlabel="label" data-testname="label valid on dl element" class="ex"> | ||
| <!-- dt/dd pending listitemkey and listitemvalue roles: https://github.com/w3c/aria/issues/1662 --> | ||
| <!-- Currently these map to `term` and `definition` for which name is prohibited. --> | ||
| <!-- Using aria-label here would be an authoring error, however there is no UA requirement to ignore the author provided role. --> |
There was a problem hiding this comment.
Actually based on the ARIA WG discussion today, perhaps we need another tentative test to invalidate this label based on the AccName update that requires ignoring nameFrom:author on roles with name prohibited. @aleventhal, what do you think?
There was a problem hiding this comment.
I think things are too much in flux rn and we should do another round of test updates once we figure out to do with name prohibited. Right now, ACCNAME says to return the empty string for prohibited names, which is counter to the test. However, I don't think there is a consensus on what actually should happen yet.
aleventhal
approved these changes
Aug 19, 2024
cookiecrook
commented
Aug 19, 2024
asamuzaK
added a commit
to asamuzaK/wpt
that referenced
this pull request
Aug 19, 2024
…istkey, associationlistvalue (web-platform-tests#47608)
Westbrook
pushed a commit
to Westbrook/wpt
that referenced
this pull request
Aug 21, 2024
…istkey, associationlistvalue (web-platform-tests#47608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes web-platform-tests/interop-accessibility#133