Replace base-select svg with disclosure-open #47672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was suggested here: w3c/csswg-drafts#10380 (comment) This patch also adds min-inline-size and min-block-size to ::select-fallback-button because changing the icon caused the total size of the button to decrease which revealed the lack of min sizing which is already tested by select-accessibility-minimum-target-size.tentative.html The UA select:open rules caused a performance regression for large <select>s because it caused a style recalc immediately after opening the appearance:auto picker which in re-serializes all of the data for the popup and sends it to the popup, which is very slow for large selects. I addressed this by starting to match :open before creating the popup in MenuListSelectType::ShowPopup. Bug: 1511354 Change-Id: Id7b3b0aa6c9c79299240a7212023f849f3703fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5660759 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1347324}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5660759
branch
from
aefd6f0
to
7e9640a
Compare
wpt-pr-bot
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested here:
w3c/csswg-drafts#10380 (comment)
This patch also adds min-inline-size and min-block-size to
::select-fallback-button because changing the icon caused the total size
of the button to decrease which revealed the lack of min sizing which is
already tested by
select-accessibility-minimum-target-size.tentative.html
The UA select:open rules caused a performance regression for large
<select>s because it caused a style recalc immediately after opening the
appearance:auto picker which in re-serializes all of the data for the
popup and sends it to the popup, which is very slow for large selects. I
addressed this by starting to match :open before creating the popup in
MenuListSelectType::ShowPopup.
Bug: 1511354
Change-Id: Id7b3b0aa6c9c79299240a7212023f849f3703fb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5660759
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1347324}