-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http cache #5137
Http cache #5137
Conversation
…http-cache # Conflicts: # fetch/http-cache/README.md
Notifying @annevk, @jdm, and @youennf. (Learn how reviewing works.) |
These tests are now available on w3c-test.org |
Firefox (nightly channel)Testing web-platform-tests at revision c3b1efa All results8 tests ran/fetch/http-cache/304-update.html
/fetch/http-cache/cc-request.html
/fetch/http-cache/freshness.html
/fetch/http-cache/heuristic.html
/fetch/http-cache/invalidate.html
/fetch/http-cache/partial.html
/fetch/http-cache/status.html
/fetch/http-cache/vary.html
|
Chrome (unstable channel)Testing web-platform-tests at revision c3b1efa All results8 tests ran/fetch/http-cache/304-update.html
/fetch/http-cache/cc-request.html
/fetch/http-cache/freshness.html
/fetch/http-cache/heuristic.html
/fetch/http-cache/invalidate.html
/fetch/http-cache/partial.html
/fetch/http-cache/status.html
/fetch/http-cache/vary.html
|
These looks good to me, as does the change to the standard. Will you file browser bugs on failures or should I? Also, you might want to consider using the .any.js convention to also test the HTTP cache from workers at close to no extra effort. |
I'm happy to file bugs. Should I do that after the tests land, so I have something to point to (that's easier to run)? WRT workers -- interesting. Do we think that the results will be any different? The cache behaviour should be the same. |
Filing bugs after is fine. I think testing workers is good, since we often think they should behave the same, but then they don't because implementers took shortcuts because threading/processes is hard. |
Firefox, Chrome and Safari pass. Will check Edge once checked in.
In particular: * Be more specific about terminology * Detail more clearly how requests are to be modified Tests: web-platform-tests/wpt#5137. During review we decided to postpone #144 (poorly implemented if at all) and #307 (also poorly implemented despite security implications). Fixes #336 and fixes #373.
Add tests for HTTP caching in Fetch. See also whatwg/fetch#496.
Caveats in README.md.