Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tabs with spaces in html/editing/dnd/ #7654

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Replace tabs with spaces in html/editing/dnd/ #7654

merged 2 commits into from
Oct 11, 2017

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 10, 2017

In every *.html, *.svg and *.xhtml file, each tab is replaced with two spaces, as this is the indentation that was most used in these test.

After replacing tabs with spaces, some odd indentation remains. Mostly found by reindenting in Emacs web-mode and looking at the differences. Most were ignored, but some are actual mistakes.

In every *.html, *.svg and *.xhtml file, each tab is replaced with two
spaces, as this is the indentation that was most used in these test.
After replacing tabs with spaces, some odd indentation remains. Mostly
found by reindenting in Emacs web-mode and looking at the differences.
Most were ignored, but some are actual mistakes.
@foolip
Copy link
Member Author

foolip commented Oct 10, 2017

Split into two commits for easier reviewing, the first is produced by simple replacement and the second contains the fixups. It's fine to squash when merging though, nobody will care after the fact.

@foolip
Copy link
Member Author

foolip commented Oct 10, 2017

I did this so that moving https://github.com/w3c/web-platform-tests/tree/master/old-tests/submission/Microsoft/dragdrop would require fixing any lint errors as well.

@w3c-bots
Copy link

w3c-bots commented Oct 10, 2017

Build ERRORED

Started: 2017-10-10 19:50:29
Finished: 2017-10-10 20:01:58

Failing Jobs

  • firefox:nightly
  • chrome:unstable
  • safari:10.0
  • MicrosoftEdge:14.14393

View more information about this build on:

@foolip
Copy link
Member Author

foolip commented Oct 10, 2017

I've filed #7660 for the Travis problem and will merge this manually if approved. @gsnedders, can you review?

@foolip foolip merged commit 3a4d676 into master Oct 11, 2017
@foolip foolip deleted the lint-dnd branch October 11, 2017 14:11
jakearchibald pushed a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
In every *.html, *.svg and *.xhtml file, each tab is replaced with two
spaces, as this is the indentation that was most used in these test.

After replacing tabs with spaces, some odd indentation remains. Mostly
found by reindenting in Emacs web-mode and looking at the differences.
Most were ignored, but some are actual mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants