Fix setTimeout lint errors around media elements #8026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In activeCues.html, the parenthesis were originally in the wrong place, causing the function to be called with 0 as this. Fortunately, this didn't matter. Fixed nonetheless.
Build PASSEDStarted: 2017-11-01 05:14:07 Failing Jobs
View more information about this build on: |
jdm
approved these changes
Nov 1, 2017
|
Looked for and didn't find any accidental regressions by comparing to https://wpt.fyi. Looking forward to #7475 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In activeCues.html, the parenthesis were originally in the wrong place,
causing the function to be called with 0 as this. Fortunately, this
didn't matter. Fixed nonetheless.
This change is