service worker: Upstream sandboxed iframe test to WPT. #8118
Conversation
Build ERROREDStarted: 2017-11-17 13:41:45 Failing Jobs
View more information about this build on: |
This test is a fine subject matter for WPT. Bug: 486308, 688116 Change-Id: I91d8484286094c695fe2219f0c017e25e8bfd34c Reviewed-on: https://chromium-review.googlesource.com/759168 Reviewed-by: Tsuyoshi Horo <[email protected]> Commit-Queue: Matt Falkenhagen <[email protected]> Cr-Commit-Position: refs/heads/master@{#515030}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-759168
branch
from
2e059c7
to
96ca6e2
Compare
|
Restarting the build |
|
I restarted the Travis jobs again and they are still failing (timeout). After looking into the log, I suspect it's a Travis capacity issue: changing the helper script makes the CI tool think a lot of service worker tests are affected, and running stability check on them easily leads to timeout. @jgraham could you take a look and see if that is correct? If so, we perhaps need to force merge this PR. |
|
@foolip see the comment above. Can you force merge the PR? Or if you don't feel comfortable about the change, can you loop in some service worker folks on the Mozilla side (apparently it has been reviewed on the Chromium side)? |
|
Sounds a bit like #7660. Since it passed Chromium's CQ we know the test aren't totally broken, so force merging. |
This test is a fine subject matter for WPT.
Bug: 486308, 688116
Change-Id: I91d8484286094c695fe2219f0c017e25e8bfd34c
Reviewed-on: https://chromium-review.googlesource.com/759168
Reviewed-by: Tsuyoshi Horo [email protected]
Commit-Queue: Matt Falkenhagen [email protected]
Cr-Commit-Position: refs/heads/master@{#515030}