Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /css/css-block/ to css/css-display/run-in/ #8437

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Nov 25, 2017

All of these tests have 'run-in' in the filename or test title,
with the lone exception first-line-pseudo-009.xht which isn't primarily
testing display: run-in but still depends on it.

The only changes are to some relative paths. (Using absolute paths here
would be shorter and more robust when renaming, but it isn't done
anywhere else in /css/, so be consistent.)

Fixes #7652.

All of these tests have 'run-in' in the filename or test title,
with the lone exception first-line-pseudo-009.xht which isn't primarily
testing `display: run-in` but still depends on it.

The only changes are to some relative paths. (Using absolute paths here
would be shorter and more robust when renaming, but it isn't done
anywhere else in /css/, so be consistent.)

Fixes #7652.
@foolip
Copy link
Member Author

foolip commented Nov 25, 2017

Reviewers, it'd be great if you just review this but don't merge it, so that I can merge it at the same time https://chromium-review.googlesource.com/c/chromium/src/+/789832, to avoid importing these tests into Chromium. (css-display is now imported, but css-block is not.)

@w3c-bots
Copy link

w3c-bots commented Nov 25, 2017

Build ERRORED

Started: 2017-11-25 21:02:42
Finished: 2017-11-25 21:36:30

Failing Jobs

  • firefox:nightly
  • MicrosoftEdge:14.14393

View more information about this build on:

Copy link
Contributor

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this helps understanding what these tests are testing easier. Didn't check all files but random picking looks good.

@foolip
Copy link
Member Author

foolip commented Nov 27, 2017

On Travis, Firefox failed like this:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

And Edge failed like this:

The job exceeded the maximum time limit for jobs, and has been terminated.

So I'll treat that as #7073 and/or #7660 and force merge this.

@foolip foolip merged commit 7a6e0b2 into master Nov 27, 2017
@foolip foolip deleted the css-block-to-run-in branch November 27, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants