Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mixin in idlharness #8727

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Add support for mixin in idlharness #8727

merged 1 commit into from
Dec 18, 2017

Conversation

romandev
Copy link
Member

@romandev romandev commented Dec 18, 2017 •
edited by wpt-reviewable-bot
Loading

This change is Reviewable

@romandev romandev mentioned this pull request Dec 18, 2017
Merged
@ghost
Copy link

ghost commented Dec 18, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-12-18 16:54:03
Finished: 2017-12-18 16:59:33

View more information about this build on:

@romandev
Copy link
Member Author

@annevk, @tobie PTAL
I made a urgent patch to fix the test error metioned in the #8700 issue. This is basically equivalent with NoInterfaceObject. After this patch, we can extend the test range (e.g. mixin members).

@annevk
Copy link
Member

annevk commented Dec 18, 2017

w3c-test:mirror

@annevk
Copy link
Member

annevk commented Dec 18, 2017

This fixes the issues @Hexcles found in #8700. The code looks reasonable, but I'm by no means an expert here.

I'm going to land this given that this seems like the most pragmatic way forward, over reverting a bunch of PRs. Post-commit reviews appreciated.

@annevk annevk merged commit f686b08 into web-platform-tests:master Dec 18, 2017
@Hexcles
Copy link
Member

Hexcles commented Dec 18, 2017

Thanks! I tested it locally and it seems to work on both Firefox and Chrome. (And I'm also not familiar with IDL. Reviews are much appreciated.)

@annevk annevk mentioned this pull request Dec 20, 2017
Merged
@foolip foolip mentioned this pull request Mar 28, 2018
Closed
@foolip foolip mentioned this pull request May 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@ayg ayg Awaiting requested review from ayg

@gsnedders gsnedders Awaiting requested review from gsnedders

@jgraham jgraham Awaiting requested review from jgraham

Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romandev @annevk @Hexcles @wpt-pr-bot