Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Add WPT tests for feature policy" #9238

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 29, 2018

This is a reland of 6252427ab5415839618a0d25e4f6e61becce3923.

Original change's description:

Add WPT tests for feature policy

  1. Added tests for header policy.
    a. document.policy shows correctly parsed policy
    b. local / remote iframes without allow attribute correctly inherit
    document.policy
    c. dynamically update allow attribute updates the policy correctly.

  2. Added tests for nested policies.

Bug: 732003
Change-Id: I869449f6bba89fc58997355df27249f403d76808
Reviewed-on: https://chromium-review.googlesource.com/796952
Commit-Queue: Luna Lu [email protected]
Reviewed-by: Ian Clelland [email protected]
Cr-Commit-Position: refs/heads/master@{#531698}

Bug: 732003
Change-Id: I46065efff8c5af2d5279721f3c759580b0807e05
Reviewed-on: https://chromium-review.googlesource.com/887324
Reviewed-by: Ian Clelland [email protected]
Commit-Queue: Luna Lu [email protected]
Cr-Commit-Position: refs/heads/master@{#538904}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@w3c-bots
Copy link

w3c-bots commented Jan 29, 2018

Build ERRORED

Started: 2018-02-24 06:01:15
Finished: 2018-02-24 06:56:39

Failing Jobs

  • firefox:nightly
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@foolip
Copy link
Member

foolip commented Feb 24, 2018

The Firefox Travis job timed out here, the log ends with "The job exceeded the maximum time limit for jobs, and has been terminated".

It's oddly similar to the way that #9641 failed, right after some certutil stuff.

Restarting that job once to see if it goes away.

@foolip
Copy link
Member

foolip commented Feb 24, 2018

Note that the Chrome job took 45 minutes, so it's possible there are just too many tests timing out here to run them 10 times within the 50 minute deadline.

@foolip
Copy link
Member

foolip commented Feb 24, 2018

Somehow unable to restart, so I'll rebase instead to get the same effect.

This is a reland of 6252427ab5415839618a0d25e4f6e61becce3923.

Original change's description:
> Add WPT tests for feature policy
>
> 1. Added tests for header policy.
>     a. document.policy shows correctly parsed policy
>     b. local / remote iframes without allow attribute correctly inherit
>        document.policy
>     c. dynamically update allow attribute updates the policy correctly.
>
> 2. Added tests for nested policies.
>
> Bug: 732003
> Change-Id: I869449f6bba89fc58997355df27249f403d76808
> Reviewed-on: https://chromium-review.googlesource.com/796952
> Commit-Queue: Luna Lu <[email protected]>
> Reviewed-by: Ian Clelland <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#531698}

Bug: 732003
Change-Id: I46065efff8c5af2d5279721f3c759580b0807e05
Reviewed-on: https://chromium-review.googlesource.com/887324
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Luna Lu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#538904}
@foolip
Copy link
Member

foolip commented Feb 25, 2018

OK, based on https://pulls.web-platform-tests.org/build/24839 and in particular https://pulls.web-platform-tests.org/job/24839.11 and the fact that the Chrome job took 46 minutes, I'm fairly confident this was a timeout problem, i.e. #7660.

I will force merge this.

@foolip foolip merged commit e494987 into master Feb 25, 2018
@foolip foolip deleted the chromium-export-cl-887324 branch February 25, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants