-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "Add WPT tests for feature policy" #9238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed downstream.
Build ERROREDStarted: 2018-02-24 06:01:15 Failing Jobs
View more information about this build on: |
507444a
to
7721f3e
Compare
199a00d
to
b4c6956
Compare
b4c6956
to
66bd0a3
Compare
The Firefox Travis job timed out here, the log ends with "The job exceeded the maximum time limit for jobs, and has been terminated". It's oddly similar to the way that #9641 failed, right after some certutil stuff. Restarting that job once to see if it goes away. |
Note that the Chrome job took 45 minutes, so it's possible there are just too many tests timing out here to run them 10 times within the 50 minute deadline. |
Somehow unable to restart, so I'll rebase instead to get the same effect. |
This is a reland of 6252427ab5415839618a0d25e4f6e61becce3923. Original change's description: > Add WPT tests for feature policy > > 1. Added tests for header policy. > a. document.policy shows correctly parsed policy > b. local / remote iframes without allow attribute correctly inherit > document.policy > c. dynamically update allow attribute updates the policy correctly. > > 2. Added tests for nested policies. > > Bug: 732003 > Change-Id: I869449f6bba89fc58997355df27249f403d76808 > Reviewed-on: https://chromium-review.googlesource.com/796952 > Commit-Queue: Luna Lu <[email protected]> > Reviewed-by: Ian Clelland <[email protected]> > Cr-Commit-Position: refs/heads/master@{#531698} Bug: 732003 Change-Id: I46065efff8c5af2d5279721f3c759580b0807e05 Reviewed-on: https://chromium-review.googlesource.com/887324 Reviewed-by: Ian Clelland <[email protected]> Commit-Queue: Luna Lu <[email protected]> Cr-Commit-Position: refs/heads/master@{#538904}
66bd0a3
to
42f037e
Compare
OK, based on https://pulls.web-platform-tests.org/build/24839 and in particular https://pulls.web-platform-tests.org/job/24839.11 and the fact that the Chrome job took 46 minutes, I'm fairly confident this was a timeout problem, i.e. #7660. I will force merge this. |
This is a reland of 6252427ab5415839618a0d25e4f6e61becce3923.
Original change's description:
Bug: 732003
Change-Id: I46065efff8c5af2d5279721f3c759580b0807e05
Reviewed-on: https://chromium-review.googlesource.com/887324
Reviewed-by: Ian Clelland [email protected]
Commit-Queue: Luna Lu [email protected]
Cr-Commit-Position: refs/heads/master@{#538904}