Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazh #9871

Closed
wants to merge 4 commits into from
Closed

Jazh #9871

wants to merge 4 commits into from

Conversation

r12a
Copy link
Contributor

@r12a r12a commented Mar 6, 2018

Test format updated to match latest i18n test suite files. Includes fixes for missing lang attributes.
中文 -> 文字
Linked to font at /fonts
CSS font meta tag removed.
Tabs, trailing spaces, and unnecessary newlines removed.
More metadata removed from ref files.
This PR includes and makes redundant #9805 (comment)

The font at /fonts is not included in this PR. See #9818 for that.

r12a added 2 commits March 6, 2018 09:08
中文 -> 文字
Linked to font at /fonts
Based on new i18n test suite format
@w3c-bots
Copy link

w3c-bots commented Mar 6, 2018

Build ERRORED

Started: 2018-03-06 10:00:12
Finished: 2018-03-06 10:35:53

Failing Jobs

  • firefox:nightly
  • chrome:dev
  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

@r12a
Copy link
Contributor Author

r12a commented Mar 7, 2018

Can someone explain to me what went wrong to produce conflicts? Thanks.

@gsnedders
Copy link
Member

Probably e45d0cf landing combined with the whitespace changes on this branch making git unable to merge automatically.

@r12a
Copy link
Contributor Author

r12a commented Mar 9, 2018

Now that #9718 (comment) has been reverted, how do i remove the conflict messages from this PR? (Assuming that that was the cause.)

@gsnedders
Copy link
Member

It wasn't reverted in the end.

@r12a
Copy link
Contributor Author

r12a commented Mar 12, 2018

Yeah. I'm waiting for the dust to settle, then i'll sort this out.
It also depends on #9818 - any plans in that regard?

@r12a
Copy link
Contributor Author

r12a commented Mar 13, 2018

Closing this to resubmit a clean version later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants