Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks PHP version bebore requiring GMP #346

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Checks PHP version bebore requiring GMP #346

merged 1 commit into from
Feb 13, 2022

Conversation

ivanwitzke
Copy link
Contributor

Fixes #316

Azuxul
Azuxul approved these changes Dec 30, 2021
View reviewed changes
Copy link

@Azuxul Azuxul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same modifications, and it is really helpful !

@marc1706
Copy link
Contributor

marc1706 commented Jan 6, 2022

I think that's a good first step. Since the minimum PHP version is set to 7.3, I think a follow up PR could be to actually remove GMP altogether since it's only used as a fallback now.

Minishlink
Minishlink approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@Minishlink Minishlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Minishlink Minishlink merged commit 6fc8c01 into web-push-libs:master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azuxul Azuxul Azuxul approved these changes

@Minishlink Minishlink Minishlink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Still requires GMP
4 participants
@ivanwitzke @marc1706 @Minishlink @Azuxul