Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop eol php #361

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Drop eol php #361

merged 4 commits into from
Jan 10, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jan 10, 2023 •
edited
Loading

  • Add php 8.2 to Github tests
  • Add extension suggestion to composer
  • Remove outdated php 7.x code
  • Github test with disabled gmp extension

Minishlink
Minishlink reviewed Jan 10, 2023
View reviewed changes
.github/ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
src/WebPush.php Show resolved Hide resolved
@Minishlink
Copy link
Member

Cool, thanks! Can you just update the typo in the issue template and we're good to go

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Jan 10, 2023

Done 👍

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Jan 10, 2023

@Minishlink rebased the pr. Found another code old php7 code snipped. Added test without gmp extension. For the other php8 migrations I will create a separate pr.

Minishlink
Minishlink approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@Minishlink Minishlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Minishlink Minishlink merged commit ec034f1 into web-push-libs:master Jan 10, 2023
@Minishlink Minishlink mentioned this pull request Jan 10, 2023
Closed
@Rotzbua Rotzbua deleted the drop_eol_php branch January 10, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minishlink Minishlink Minishlink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rotzbua @Minishlink