Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add types #387

Merged
merged 1 commit into from
Jan 30, 2024
Merged

feat: add types #387

merged 1 commit into from
Jan 30, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jan 30, 2024

Changes

  • add types
  • simplify constructor

@Rotzbua
feat: add types
f0feaa0 
simplify constructor
Minishlink
Minishlink approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@Minishlink Minishlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Minishlink Minishlink merged commit fd2d54a into web-push-libs:master Jan 30, 2024
6 checks passed
@Rotzbua Rotzbua deleted the feat_type branch January 30, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minishlink Minishlink Minishlink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rotzbua @Minishlink