6508 fix (#6509)

* fixed issue, unit test and changelog * changelog
web3 · Oct 17, 2023 · 226b3ba · 226b3ba
1 parent 70d1957
commit 226b3ba
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/packages/web3-eth/CHANGELOG.md b/packages/web3-eth/CHANGELOG.md
@@ -201,6 +201,7 @@ Documentation:
 
 -   Ensure provider.supportsSubscriptions exists before watching by subscription (#6440)
 -   Fixed param sent to `checkRevertBeforeSending` in `sendSignedTransaction` 
+-   Fixed `defaultTransactionBuilder` for value issue (#6509)
 
 ### Added
 

diff --git a/packages/web3-eth/src/utils/transaction_builder.ts b/packages/web3-eth/src/utils/transaction_builder.ts
@@ -155,7 +155,7 @@ export async function defaultTransactionBuilder<ReturnType = Transaction>(option
 	}
 
 	if (isNullish(populatedTransaction.value)) {
-		populatedTransaction.value = '0x';
+		populatedTransaction.value = '0x0';
 	}
 
 	if (!isNullish(populatedTransaction.data)) {

diff --git a/packages/web3-eth/test/unit/default_transaction_builder.test.ts b/packages/web3-eth/test/unit/default_transaction_builder.test.ts
@@ -228,7 +228,7 @@ describe('defaultTransactionBuilder', () => {
 	});
 
 	describe('should populate value', () => {
-		it('should populate with 0x', async () => {
+		it('should populate with 0x0 if not provided', async () => {
 			const input = { ...transaction };
 			delete input.value;
 			delete input.maxPriorityFeePerGas;
@@ -239,7 +239,21 @@ describe('defaultTransactionBuilder', () => {
 				web3Context,
 				fillGasPrice: true,
 			});
-			expect(result.value).toBe('0x');
+			expect(result.value).toBe('0x0');
+		});
+
+
+		it('should not populate with 0x0 if provided', async () => {
+			const input = { ...transaction };
+			delete input.maxPriorityFeePerGas;
+			delete input.maxFeePerGas;
+
+			const result = await defaultTransactionBuilder({
+				transaction: input,
+				web3Context,
+				fillGasPrice: true,
+			});
+			expect(result.value).not.toBe('0x0');
 		});
 	});