Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signTransaction should always return promises #1213

Closed
phra opened this issue Dec 6, 2017 · 0 comments
Closed

signTransaction should always return promises #1213

phra opened this issue Dec 6, 2017 · 0 comments

Comments

@phra
Copy link
Contributor

phra commented Dec 6, 2017 •
edited
Loading

related to web3 1.0

i strongly suggest to adopt this pattern for every use case because it will make the dev ux smoother.
phra added a commit to phra/web3.js that referenced this issue Dec 6, 2017
@phra
fix: make signTransaction return a promise, fixes web3#1213
f2f3725
phra added a commit to phra/web3.js that referenced this issue Dec 6, 2017
@phra
fix: make signTransaction return a promise, fixes web3#1213
e5e89e6
phra added a commit to phra/web3.js that referenced this issue Dec 21, 2017
@phra
fix: make signTransaction return a promise, fixes web3#1213
f7f687d
phra added a commit to phra/web3.js that referenced this issue Jan 12, 2018
@phra
fix: make signTransaction return a promise, fixes web3#1213
e0e0edd
frozeman pushed a commit that referenced this issue Jan 22, 2018
@phra @frozeman
fix: make signTransaction return a promise, fixes #1213 (#1214)
dea396d 
* fix: make signTransaction return a promise, fixes #1213

* test: fix failing tests for #1214

* refactor: backport sign transaction changes to es5
@nivida nivida closed this as completed Aug 9, 2018
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this issue Jun 4, 2020
@phra @nachomazzara
fix: make signTransaction return a promise, fixes web3#1213 (web3#1214)
ca001d5 
* fix: make signTransaction return a promise, fixes web3#1213

* test: fix failing tests for web3#1214

* refactor: backport sign transaction changes to es5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phra @nivida