Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity compatibility #1243

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Conversation

7flash
Copy link

@7flash 7flash commented Dec 21, 2017

Truffle expects null returned as receipt when transaction is still pending, parity returns normal receipt but with blockHash == null.
(https://github.com/Neufund/parity-instant-seal-byzantium-enabled#deployment-with-truffle)

This change was already proposed by @MarcoGuarducci(#1028)
But we really need to merge it as soon as possible because it fixes following issues:
openethereum/parity-ethereum#5538
trufflesuite/truffle-migrate#15
trufflesuite/truffle#558

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.63% when pulling e7d7d80 on 7flash:parity-compatibility-fix into de3d64a on ethereum:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.63% when pulling e7d7d80 on 7flash:parity-compatibility-fix into de3d64a on ethereum:develop.

Copy link

@lexruster lexruster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move changes

@frozeman frozeman merged commit 013b23e into web3:develop Jan 11, 2018
@Tudmotu
Copy link

Tudmotu commented May 20, 2018

Hi :)
Is it possible this is still an issue with the 1.0.0-beta version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants