Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AllEventsLogDecoder improved #2392

Merged
merged 4 commits into from
Feb 20, 2019
Merged

AllEventsLogDecoder improved #2392

merged 4 commits into from
Feb 20, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Feb 19, 2019 •
edited
Loading

Description

Fixes #2365

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Feb 19, 2019
@nivida nivida removed the In Progress Currently being worked on label Feb 19, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 93.179% when pulling c82f8ea on issue/2365 into ac0dde7 on 1.0.

@nivida
Copy link
Contributor Author

nivida commented Feb 20, 2019

The build succeed it just had problems with dtslint and travis. I've tested it locally with the version 6 and 7 of nodejs and it worked.

@nivida nivida merged commit c3fce57 into 1.0 Feb 20, 2019
@nivida nivida deleted the issue/2365 branch February 20, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
2 participants
@nivida @coveralls