Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthSendTransactionMethod simplified and fixed for local signing #2616

Merged
merged 12 commits into from
Apr 1, 2019
Merged

EthSendTransactionMethod simplified and fixed for local signing #2616

merged 12 commits into from
Apr 1, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 29, 2019 •
edited
Loading

Description

Fixes #2612 #2601

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Mar 29, 2019
@coveralls
Copy link

coveralls commented Apr 1, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 95.33% when pulling 0dd5f02 on issue/2612 into 26987f6 on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Apr 1, 2019
@nivida nivida merged commit 60adc23 into 1.0 Apr 1, 2019
@nivida nivida deleted the issue/2612 branch April 1, 2019 10:51
@nivida nivida mentioned this pull request Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't get tx receipt of reverted transaction
2 participants
@nivida @coveralls