Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebSocketProvider reconnection events #2811

Closed
wants to merge 3 commits into from
Closed

Fix WebSocketProvider reconnection events #2811

wants to merge 3 commits into from

Conversation

boomfly
Copy link

@boomfly boomfly commented May 11, 2019 •
edited by nivida
Loading

Description

Please include a summary of the change.

issue #2711

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.957% when pulling 70b0ad3 on boomfly:1.0 into 9528160 on ethereum:1.0.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.957% when pulling 70b0ad3 on boomfly:1.0 into 9528160 on ethereum:1.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.957% when pulling 70b0ad3 on boomfly:1.0 into 9528160 on ethereum:1.0.

boomfly
boomfly commented May 11, 2019
View reviewed changes
package.json Show resolved Hide resolved
@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels May 13, 2019
@nivida nivida self-requested a review May 13, 2019 09:58
@ersanyakit ersanyakit mentioned this pull request May 15, 2019
Closed
@nivida nivida mentioned this pull request May 28, 2019
Closed
@nivida
Copy link
Contributor

nivida commented May 29, 2019

Thanks for providing me these fixes! I've improved your solution and will do some additional tests. PR: #2855

@nivida nivida closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida Awaiting requested review from nivida

Assignees
No one assigned
Labels
Bug Addressing a bug In Progress Currently being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boomfly @coveralls @nivida