Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscription.js Emit 'connected' event with subscription.id #3028

Merged
merged 7 commits into from
Oct 17, 2019
Merged

subscription.js Emit 'connected' event with subscription.id #3028

merged 7 commits into from
Oct 17, 2019

Conversation

lbertenasco
Copy link
Contributor

Would something like this be possible to add?
It's useful when testing WS subscriptions successful connections.
Instead of retrying get subscription.id until it's defined.

@lbertenasco lbertenasco changed the title Update subscription.js subscription.js Emit 'connected' event with subscription.id Aug 15, 2019
@coveralls
Copy link

coveralls commented Aug 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 84.834% when pulling 48918ba on lbertenasco:patch-1 into ba56fc6 on ethereum:1.x.

@nivida nivida added 1.x 1.0 related issues Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Aug 16, 2019
nivida
nivida suggested changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this PR! Could you please update the changelog file located in the root folder of this branch? and also extend the documentation?

@lbertenasco
Copy link
Contributor Author

Thanks for proposing this PR! Could you please update the changelog file located in the root folder of this branch? and also extend the documentation?

Changelog and docs updated 👍

@nivida nivida removed the In Progress Currently being worked on label Oct 17, 2019
@nivida nivida merged commit cf96133 into web3:1.x Oct 17, 2019
@lbertenasco lbertenasco deleted the patch-1 branch October 18, 2019 01:37
@nivida nivida mentioned this pull request Oct 21, 2019
Merged
11 tasks
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@lbertenasco @nachomazzara
subscription.js Emit 'connected' event with subscription.id (web3#3028)
141a2fc 
* Update subscription.js

* Updates Changelog and Docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lbertenasco @coveralls @nivida @gnidan @alcuadrado @iurimatias @spalladino