Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 'null' receipt.status values #3090

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Allow 'null' receipt.status values #3090

merged 4 commits into from
Oct 8, 2019

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Oct 2, 2019 •
edited
Loading

Fixes #2183 and verifies that #2401 is fixed on 1.x.

Back-ports 2.x outputTransactionReceiptFormatter tests and adding cases for statuses:

  • 0x1,
  • 0x01
  • undefined
  • null

NB: null and undefined are passed through uninterpreted & unmodified.

@alcuadrado alcuadrado mentioned this pull request Oct 2, 2019
Closed
@coveralls
Copy link

coveralls commented Oct 2, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 83.02% when pulling 532e918 on cgewecke:backport/2401 into 35b2e22 on ethereum:1.x.

@cgewecke cgewecke added the 1.x 1.0 related issues label Oct 2, 2019
@cgewecke cgewecke mentioned this pull request Oct 7, 2019
Closed
@cgewecke cgewecke changed the title Add outputTransactionReceiptFormatter tests Allow 'null' receipt.status values Oct 7, 2019
@nivida nivida added the Bug Addressing a bug label Oct 7, 2019
nivida
nivida suggested changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you update the changelog?

@nivida nivida merged commit 4b91f10 into web3:1.x Oct 8, 2019
@cgewecke cgewecke deleted the backport/2401 branch October 8, 2019 05:27
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
@cgewecke @nachomazzara
Allow 'null' receipt.status values (web3#3090)
2bb8d60 
* Add outputTransactionReceiptFormatter tests

* Allow null receipt.status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgewecke @coveralls @nivida @gabmontes