Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-subscribing moved to RequestManager #3187

Closed
wants to merge 1 commit into from

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 7, 2019

Description

This PR does have PR #3167 as the base and does move the logic to trigger subscriptions to re-subscribe to the RequestManager. In addition, did I exchange the subscriptions Array with a Map and was able to simplify related loops.

This improvement is depending on PR #3156 because otherwise the connect listener we use in the RequestManager gets registered and triggered multiple times.

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

…cribing after the connection got lost will now get triggered from the RequestManager instead of the subscriptions
@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on 1.x 1.0 related issues labels Nov 7, 2019
@nivida nivida changed the base branch from 1.x to staging/reconnect-resubscribe November 7, 2019 16:13
@nivida nivida mentioned this pull request Nov 8, 2019
11 tasks
@nivida nivida closed this Nov 8, 2019
@nivida nivida deleted the resubscribing-improved branch December 12, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations In Progress Currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant