Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_requestAccounts added to web3-eth package #3219

Merged
merged 3 commits into from
Nov 21, 2019
Merged

eth_requestAccounts added to web3-eth package #3219

merged 3 commits into from
Nov 21, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 19, 2019 •
edited
Loading

Description

This PR does add the JSON-RPC method eth_requestAccounts to the web3-eth package.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test with success and extended the tests if necessary.
  • I ran npm run build and tested the resulting file from dist folder in a browser.
  • I have tested my code on the live network.

@nivida nivida added Feature Request 1.x 1.0 related issues In Progress Currently being worked on labels Nov 19, 2019
@coveralls
Copy link

coveralls commented Nov 19, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 84.347% when pulling 85dc0ee on feature-request/requestAccounts into ca9869f on 1.x.

@nivida nivida removed the In Progress Currently being worked on label Nov 19, 2019
@nivida nivida requested a review from cgewecke November 19, 2019 10:30
@cgewecke cgewecke self-requested a review November 20, 2019 01:04
cgewecke
cgewecke reviewed Nov 20, 2019
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my question about address formatting this LGTM! It's cool.

Did you try it with metamask?

@nivida
Copy link
Contributor Author

nivida commented Nov 20, 2019

Did you try it with metamask?

Yep, if I'm right does Status, imToken, and WalletConnect support this JSON-RPC method as well.

@nivida nivida requested a review from cgewecke November 20, 2019 08:07
cgewecke
cgewecke approved these changes Nov 20, 2019
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nivida nivida merged commit 0109937 into 1.x Nov 21, 2019
@nivida nivida deleted the feature-request/requestAccounts branch November 21, 2019 15:44
@nivida nivida mentioned this pull request Nov 30, 2019
Closed
@nivida nivida mentioned this pull request Jan 16, 2020
Merged
10 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nivida @coveralls @cgewecke