Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clearSubscriptions shouldn't throw an error if no subscriptions do exist #3246

Merged
merged 3 commits into from
Nov 29, 2019
Merged

clearSubscriptions shouldn't throw an error if no subscriptions do exist #3246

merged 3 commits into from
Nov 29, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 28, 2019 •
edited
Loading

Description

Fixes #3245

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added Bug Addressing a bug 1.x 1.0 related issues labels Nov 28, 2019
@coveralls
Copy link

coveralls commented Nov 28, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 84.453% when pulling 401d6d6 on issue/3245 into c9482d7 on 1.x.

@nivida nivida marked this pull request as ready for review November 28, 2019 09:08
@nivida nivida requested a review from cgewecke November 28, 2019 09:08
@nivida nivida added the Review Needed Maintainer(s) need to review label Nov 28, 2019
cgewecke
cgewecke approved these changes Nov 28, 2019
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nivida nivida merged commit 02b695a into 1.x Nov 29, 2019
@nivida nivida removed the Review Needed Maintainer(s) need to review label Nov 29, 2019
@nivida nivida deleted the issue/3245 branch December 9, 2019 09:58
@nivida nivida mentioned this pull request Jan 16, 2020
Merged
10 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
This was referenced Feb 16, 2023
Open
Open
This was referenced Feb 23, 2023
Open
Open
@snyk-bot snyk-bot mentioned this pull request Feb 26, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Feb 27, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Feb 28, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Mar 1, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 2, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Mar 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth.clearSubscriptions gives error if no running subscriptions do exist
3 participants
@nivida @coveralls @cgewecke