Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CDN for web3.js #3273

Merged
merged 2 commits into from
Jan 16, 2020
Merged

add CDN for web3.js #3273

merged 2 commits into from
Jan 16, 2020

Conversation

BesrourMS
Copy link
Contributor

@BesrourMS BesrourMS commented Dec 14, 2019

Description

Please include a summary of the change.

#1492 #3074

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented Dec 14, 2019

Coverage Status

Coverage remained the same at 84.802% when pulling f2682d9 on BesrourMS:patch-1 into 4689592 on ethereum:1.x.

@nivida nivida added 1.x 1.0 related issues Documentation Relates to project wiki or documentation labels Dec 16, 2019
README.md Outdated Show resolved Hide resolved
Co-Authored-By: Samuel Furter <[email protected]>
@nivida nivida changed the base branch from 1.x to release/1.2.5 January 16, 2020 10:00
@nivida nivida merged commit 84543a0 into web3:release/1.2.5 Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants