Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback type for Accounts.signTransaction fixed #3280

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Callback type for Accounts.signTransaction fixed #3280

merged 2 commits into from
Dec 19, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Dec 18, 2019

Description

This PR adds the callback parameters with his types to the type definition of the Accounts.signTransaction method.

Fixes #3278

Type of change

  • Types

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added Types Incorrect or missing types 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Dec 18, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.802% when pulling f1448b2 on issue/3278 into 4d57461 on 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type of callback for web3.eth.accounts.signTransaction is incorrect
2 participants