Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for websocket connection errors #3302

Closed
wants to merge 1 commit into from

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Jan 10, 2020

Description

These are the same tests proposed for #3190 but aimed at 1.x. They show that the current 1.x behavior when connecting to a non-existent url is to fire an error with this message

connection not open on send

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.141% when pulling 08dac48 on test/websocket-err-baseline into 9b4b68a on 1.x.

@cgewecke cgewecke mentioned this pull request Jan 10, 2020
11 tasks
@nivida
Copy link
Contributor

nivida commented Jan 13, 2020

@cgewecke Thanks for creating this! I'm wondering why the requirement now is to have this error message in PR #3190 and why you were arguing to not have it in PR #3171.

@cgewecke
Copy link
Collaborator Author

@nivida RE: #3171 could you explain further? I've just checked and the only thing I see is a discussion about whether it's safe to remove the console.error('connection not open on send()').

@cgewecke
Copy link
Collaborator Author

This was discussed at the web3 meeting and is close-able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants