Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core-method tests for http confirmations & wallet chain options #3311

Merged
merged 4 commits into from
Jan 15, 2020

Conversation

cgewecke
Copy link
Collaborator

Description

Adds some additional test coverage to web3-core-method for:

  • confirmations over http
  • method calls made with a wallet address using the default chain, hardfork and common options

Because of the 1s polling interval, am only testing confirmations with geth automine.

Type of change

  • Tests

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented Jan 14, 2020

Coverage Status

Coverage increased (+0.4%) to 85.36% when pulling 0bf0bc9 on test/conf-http into 3f839c9 on 1.x.

@cgewecke cgewecke added 1.x 1.0 related issues Testing labels Jan 14, 2020
@cgewecke cgewecke requested a review from nivida January 14, 2020 18:37
@cgewecke cgewecke added the Review Needed Maintainer(s) need to review label Jan 14, 2020
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nivida nivida merged commit 513116f into 1.x Jan 15, 2020
@nivida nivida deleted the test/conf-http branch January 16, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants