Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 1.2.6 (new PR #3353) #3351

Closed
wants to merge 6 commits into from
Closed

Release - 1.2.6 (new PR #3353) #3351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f32f507
CHANGELOG.md and root package.json updated
nivida Jan 30, 2020
d4ebd30
ENS registry address updated
nivida Jan 30, 2020
55eff53
ENS testnet registry addresses updated
nivida Jan 30, 2020
d5cb70d
CHANGELOG.md updated
nivida Jan 30, 2020
632cf9a
ENS test updated
nivida Jan 30, 2020
1ccfe27
web3.min.js updated and locally tested
nivida Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ Released with 1.0.0-beta.37 code base.
- fix: export bloom functions on the index.js
- Prefer receipt status to code availability on contract deployment (#3298)

## [Unreleased]

## [1.2.6]

### Added
Expand All @@ -137,7 +135,12 @@ Released with 1.0.0-beta.37 code base.
### Changed

- Ensure '0x' prefix is existing for Accounts.sign and Accounts.privateKeyToAccount (#3041)
- All ENS registry addresses changed to the newly deployed Registry address

### Fixed

- Add missing subscription.on('connected') TS type definition (#3319)

## [Unreleased]

## [1.2.7]
2 changes: 1 addition & 1 deletion dist/web3.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "web3",
"private": true,
"version": "1.2.5",
"version": "1.2.6",
"description": "Ethereum JavaScript API wrapper repository",
"license": "LGPL-3.0",
"engines": {
Expand Down
8 changes: 4 additions & 4 deletions packages/web3-eth-ens/src/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
*/
var config = {
addresses: {
main: "0x314159265dD8dbb310642f98f50C066173C1259b",
ropsten: "0x112234455c3a32fd11230c42e7bccd4a84e02010",
rinkeby: "0xe7410170f87102df0055eb195163a03b7f2bff4a",
goerli: "0x112234455C3a32FD11230C42E7Bccd4A84e02010"
main: "0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e",
ropsten: "0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e",
rinkeby: "0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e",
goerli: "0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e"
nivida marked this conversation as resolved.
Show resolved Hide resolved
},
};

Expand Down
13 changes: 7 additions & 6 deletions test/eth.ens.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('ens', function () {
assert.equal(payload.method, 'eth_call');
assert.deepEqual(payload.params, [{
data: sha3(signature).slice(0, 10) + '1757b5941987904c18c7594de32c1726cda093fdddacb738cfbc4a7cd1ef4370',
to: '0x314159265dd8dbb310642f98f50c066173c1259b',
to: '0x00000000000c2e074ec69a0dfb2997ba6c7d2e1e',
}, 'latest']);
});
provider.injectResult('0x0000000000000000000000000123456701234567012345670123456701234567');
Expand All @@ -73,7 +73,7 @@ describe('ens', function () {
assert.equal(payload.method, 'eth_call');
assert.deepEqual(payload.params, [{
data: sha3(signature).slice(0, 10) + '1757b5941987904c18c7594de32c1726cda093fdddacb738cfbc4a7cd1ef4370',
to: '0x314159265dd8dbb310642f98f50c066173c1259b',
to: '0x00000000000c2e074ec69a0dfb2997ba6c7d2e1e',
}, 'latest']);
});
provider.injectResult('0x0000000000000000000000000123456701234567012345670123456701234567');
Expand All @@ -91,11 +91,12 @@ describe('ens', function () {
var addrSig = 'addr(bytes32)';

provider.injectValidation(function (payload) {
console.log(payload.params);
assert.equal(payload.jsonrpc, '2.0');
assert.equal(payload.method, 'eth_call');
assert.deepEqual(payload.params, [{
data: sha3(resolverSig).slice(0, 10) + '1757b5941987904c18c7594de32c1726cda093fdddacb738cfbc4a7cd1ef4370',
to: '0x314159265dd8dbb310642f98f50c066173c1259b',
to: '0x00000000000c2e074ec69a0dfb2997ba6c7d2e1e',
}, 'latest']);
});
provider.injectResult('0x0000000000000000000000000123456701234567012345670123456701234567');
Expand Down Expand Up @@ -127,7 +128,7 @@ describe('ens', function () {
assert.equal(payload.method, 'eth_call');
assert.deepEqual(payload.params, [{
data: sha3(resolverSignature).slice(0, 10) + '1757b5941987904c18c7594de32c1726cda093fdddacb738cfbc4a7cd1ef4370',
to: '0x314159265dd8dbb310642f98f50c066173c1259b',
to: '0x00000000000c2e074ec69a0dfb2997ba6c7d2e1e',
}, 'latest']);
});
provider.injectResult('0x0000000000000000000000000123456701234567012345670123456701234567');
Expand Down Expand Up @@ -163,7 +164,7 @@ describe('ens', function () {
assert.equal(payload.method, 'eth_call');
assert.deepEqual(payload.params, [{
data: sha3(resolverSignature).slice(0, 10) + '1757b5941987904c18c7594de32c1726cda093fdddacb738cfbc4a7cd1ef4370',
to: '0x314159265dd8dbb310642f98f50c066173c1259b',
to: '0x00000000000c2e074ec69a0dfb2997ba6c7d2e1e',
}, 'latest']);
});
provider.injectResult('0x0000000000000000000000000123456701234567012345670123456701234567');
Expand Down Expand Up @@ -265,7 +266,7 @@ describe('ens', function () {
describe('custom registry address', function () {
let web3;
let provider;
const address = '0x314159265dD8dbb310642f98f50C066173C1259b';
const address = '0x00000000000c2e074ec69a0dfb2997ba6c7d2e1e';

beforeEach(function () {
provider = new FakeHttpProvider();
Expand Down