-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CI Provider from Travis to GH Actions #3468
Conversation
.github/workflows/test.yml
Outdated
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node: [8, 10, 11, 12] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does 13 also work by any chance? (Was reminded about this possibility by #3473....)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i'll add it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like ran into the same error: https://github.com/ethereum/web3.js/pull/3468/checks?check_run_id=590277057#step:4:64
ed17f84
to
7bacb68
Compare
7bacb68
to
c08aeea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🎉
Ai! Build!!! Why?? |
Description
This PR upgrades the CI provider from Travis to GH Actions for better speed and workflow integration.
This PR:
coveralls
devDep in favor pushing to Coveralls through GH Actions.yarn
as a fallback upstream proxy.Closes #3393
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases do cover all lines and branches of the added code.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.