Add --ignore-scripts to lerna publish command for E2E publishing tests #3472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR targets #3470
In #3470, the publishing steps are managed with npm lifecycle scripts. However the E2E npm installation tests don't install the dev dependencies required for the build (in order to preserve as much dep. isolation as possible) so that step fails.
We don't use the minified bundle in these tests so we can safely skip here...
The target branch for this is an open question...it might be nice to see those tests pass for the release and they're intended as pre-publication sanity checks. On the other hand maybe this fix belongs outside the release process.
(The tests pass here ... it could be floated in next week after the release is complete)
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases do cover all lines and branches of the added code.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.