Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose bundlesize token in GH Actions CI #3495

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Expose bundlesize token in GH Actions CI #3495

merged 1 commit into from
Apr 29, 2020

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Apr 29, 2020

Description

In #3260 we added a bundle size checker to CI to track minified package size increases (cf: #1178). It relies on a CI env secret that needs to be ported to GH actions.

Looks like this on Travis:

Screen Shot 2019-12-07 at 1 12 08 PM

Type of change

  • CI tuning 🎶

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.

@cgewecke cgewecke added 1.x 1.0 related issues CI Review Needed Maintainer(s) need to review labels Apr 29, 2020
Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants