Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin geth docker version to v1.9.13 #3519

Merged
merged 1 commit into from
May 13, 2020
Merged

Pin geth docker version to v1.9.13 #3519

merged 1 commit into from
May 13, 2020

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented May 13, 2020

Description

The revert reason tests are failing against the geth stable tag published today (v.1.9.14).

At first glance it looks like geth is no longer passing back the return data which encodes reason strings when failing transactions are replayed as calls.

(A temporary patch to get CI working again - issue is under investigation).

Type of change

  • CI fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • My changes generate no new warnings.

Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it worked, thanks!

@ryanio ryanio merged commit 4ec98d4 into 1.x May 13, 2020
@ryanio ryanio added 1.x 1.0 related issues CI labels May 14, 2020
@mpetrunic mpetrunic deleted the fix/geth-ci branch October 31, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants