Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsubscribe and add a test #4058

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Fix unsubscribe and add a test #4058

merged 3 commits into from
Sep 8, 2021

Conversation

samlior
Copy link

@samlior samlior commented May 11, 2021

Description

Fix unsubscribe and add a test.
#3992

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@samlior
Copy link
Author

samlior commented May 11, 2021

@spacesailor24

@coveralls
Copy link

coveralls commented May 27, 2021

Pull Request Test Coverage Report for Build 1210555715

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 422 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.6%) to 72.908%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 24 80.65%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 85 13.04%
packages/web3-eth-accounts/src/index.js 164 25.31%
Totals Coverage Status
Change from base Build 1195730440: -2.6%
Covered Lines: 3324
Relevant Lines: 4310

💛 - Coveralls

@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jul 27, 2021
@github-actions github-actions bot closed this Aug 10, 2021
@philknows philknows reopened this Sep 2, 2021
@philknows philknows linked an issue Sep 2, 2021 that may be closed by this pull request
@philknows philknows removed the Stale Has not received enough activity label Sep 2, 2021
@spacesailor24
Copy link
Contributor

Thank you for opening this PR, apologies it took so long to be looked at

Test failure is unrelated to changes, this looks good minus the CHANGELOG.md needing to be updated (but I can take care of that)

I believe the test failure is related to #3816, I will be working on updating our tests so this is unblocked

Thank you for your patience

@spacesailor24 spacesailor24 changed the base branch from 1.x to wyatt/4058-unsubscribe-fix September 8, 2021 03:45
@spacesailor24 spacesailor24 merged commit 37d3f7a into web3:wyatt/4058-unsubscribe-fix Sep 8, 2021
spacesailor24 added a commit that referenced this pull request Oct 5, 2021
* Fix unsubscribe and add a test (#4058)

Co-authored-by: Alex <[email protected]>
Co-authored-by: Wyatt Barnes <[email protected]>

* Update CHANGELOG

Co-authored-by: Samlior <[email protected]>
Co-authored-by: Alex <[email protected]>
@luu-alex luu-alex mentioned this pull request Jul 29, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Did not send eth_unsubscribe to the node when unsubscribing
4 participants