Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make disconnect params optional in types #4833

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Make disconnect params optional in types #4833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f339e00
Make disconnect params optional in types
wbt Mar 8, 2022
67032bc
Update changelog, including PR number
wbt Mar 8, 2022
f3c9117
Update refs to old discussions,
wbt Mar 8, 2022
1b92da2
Merge branch '1.x' into patch-4
wbt Mar 14, 2022
4778983
PR under 1.7.2
jdevcs Mar 17, 2022
e5dd64a
Merge branch '1.x' into patch-4
jdevcs Mar 17, 2022
1a853a9
Merge branch '1.x' into patch-4
jdevcs Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,4 +533,4 @@ Released with 1.0.0-beta.37 code base.

### Fixed
- Fix jsonrpc payload and response types (#4743) (#4761)

- Allowed more flexibility in typing the overly constrained `provider.disconnect` function (#4833)
3 changes: 2 additions & 1 deletion CONTRIBUTIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,5 @@ Emergency releases are allowed to shorten waiting periods depending on the sever

There is precedent set for this in the 1.2.6 release (see [#3351](https://github.com/ethereum/web3.js/pull/3351)), where the consensus view was to make the smallest change necessary to address the emergency while waiving the `rc` process (meaning many existing additions to master were excluded).

This topic is under further org-wide discussion at [ethereum/js-organization#6](https://github.com/ethereum/js-organization/issues/6).
This topic was under further org-wide discussion [here](https://github.com/ethereum/js-organization/issues/6)
and [here](https://github.com/ChainSafe/web3.js/issues/3358).
2 changes: 1 addition & 1 deletion packages/web3-core-helpers/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class WebsocketProviderBase {

reset(): void;

disconnect(code: number, reason: string): void;
disconnect(code?: number, reason?: string): void;

connect(): void;

Expand Down