-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typos in web3-eth-accounts.rst & TESTING.md #5047 #5048
Conversation
@andreistefanwork Please add an entry to the |
6ee01be
to
04427e5
Compare
@nazarhussain Thanks for checking it out, entry added in |
CHANGELOG.md
Outdated
@@ -548,6 +548,7 @@ Released with 1.0.0-beta.37 code base. | |||
- Fix static tuple encoding (#4673) (#4884) | |||
- Fix bug in handleRevert logic for eth_sendRawTransaction (#4902) | |||
- Fix resolve type of getBlock function (#4911) | |||
- Fix typos in web3-eth-accounts.rst & TESTING.md (#5047) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be under 1.7.5 as 1.7.4 is already frozen. https://github.com/ChainSafe/web3.js/blob/release/1.7.4/CHANGELOG.md#174
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct .. should I add the 1.7.5 entry in CHANGELOG.md
? (it's not in the file on 1.x currently)
1239111
to
2841520
Compare
2841520
to
6b23054
Compare
6b23054
to
32c9c36
Compare
32c9c36
to
434a58c
Compare
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.