Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in web3-eth-accounts.rst & TESTING.md #5047 #5048

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

andreistefanwork
Copy link

@andreistefanwork andreistefanwork commented May 17, 2022

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@nazarhussain
Copy link
Contributor

@andreistefanwork Please add an entry to the CHANGELOG.md referring the issue. Rest LGTM.

@andreistefanwork
Copy link
Author

@nazarhussain Thanks for checking it out, entry added in CHANGELOG.md

CHANGELOG.md Outdated
@@ -548,6 +548,7 @@ Released with 1.0.0-beta.37 code base.
- Fix static tuple encoding (#4673) (#4884)
- Fix bug in handleRevert logic for eth_sendRawTransaction (#4902)
- Fix resolve type of getBlock function (#4911)
- Fix typos in web3-eth-accounts.rst & TESTING.md (#5047)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be under 1.7.5 as 1.7.4 is already frozen. https://github.com/ChainSafe/web3.js/blob/release/1.7.4/CHANGELOG.md#174

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct .. should I add the 1.7.5 entry in CHANGELOG.md? (it's not in the file on 1.x currently)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Future Release For future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small spelling errors in web3-eth-accounts.rst & TESTING.md
5 participants