Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AbstractProvider with correct typing #5206

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Update AbstractProvider with correct typing #5206

merged 2 commits into from
Jul 5, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jul 5, 2022

Description

This PR is opened for checking Build / e2e_windows (pull_request) of #5158

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@Dinatra @jdevcs
🏷️ Update AbstractProvider with correct typing (#5158)
fb48047 
* 🏷️ Update AbstractProvider with correct typing

* Update AbstractProvider sendAsync cb return type

* 📝 Updating the changelog

* 🏷️ Updating return type of callback from AbstractProvider sendAsync method

Co-authored-by: Junaid <[email protected]>
@jdevcs jdevcs self-assigned this Jul 5, 2022
@render
Copy link

render bot commented Jul 5, 2022

Your Render PR Server URL is https://web3-js-pr-5206.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cb22qmvs437h7vo6j85g.

@coveralls
Copy link

coveralls commented Jul 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2616127289

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 267 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 74.342%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 8 84.3%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 45 10.67%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 2615970841: 2.3%
Covered Lines: 3262
Relevant Lines: 4138
💛 - Coveralls

@jdevcs
Copy link
Contributor Author

jdevcs commented Jul 5, 2022

Code changes of this PR were already approved in #5158, and CI is green in this PR so merging in 1.x

@jdevcs jdevcs merged commit 35d8f7f into 1.x Jul 5, 2022
@jdevcs jdevcs deleted the junaid/abstractprovidertype branch July 5, 2022 12:40
@jdevcs jdevcs mentioned this pull request Jul 5, 2022
Merged
16 tasks
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdevcs jdevcs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdevcs @coveralls @Dinatra