Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x Libs Update including parse-url #5254

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jul 15, 2022

Description

#5253

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs added the 1.x 1.0 related issues label Jul 15, 2022
@jdevcs jdevcs self-assigned this Jul 15, 2022
@render
Copy link

render bot commented Jul 15, 2022

@coveralls
Copy link

coveralls commented Jul 15, 2022

Pull Request Test Coverage Report for Build 2678699476

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 268 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 74.388%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 8 84.3%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 45 10.67%
packages/web3-eth-accounts/src/index.js 108 23.67%
Totals Coverage Status
Change from base Build 2677775255: 2.3%
Covered Lines: 3265
Relevant Lines: 4139

💛 - Coveralls

@jdevcs jdevcs merged commit fc7bfcd into 1.x Jul 15, 2022
@jdevcs jdevcs deleted the junaid/1xparse-urlLibUpdateInPath branch July 15, 2022 19:11
@jdevcs jdevcs mentioned this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants