Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.x tests infrastructure/libs #5671

Merged
merged 40 commits into from
Jan 4, 2023

Conversation

nikoulai
Copy link
Contributor

@nikoulai nikoulai commented Dec 1, 2022

Description

closes #5630

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@nikoulai nikoulai force-pushed the nikos/5630/update-1.x-tests-infrastructure/libs branch from 2dc84cb to 5f46269 Compare December 5, 2022 09:43
package.json Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 6, 2022

Pull Request Test Coverage Report for Build 3704398011

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 75.028%

Totals Coverage Status
Change from base Build 3658689056: 0.4%
Covered Lines: 3299
Relevant Lines: 4146

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues dependencies Updates dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 1.x tests infrastructure / libs
5 participants