-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging of connection errors #5955
Conversation
Fixes. web3#5954 Existing code gobbles up the real error and only prints a generic message with the URL. This change utilizes the error object to give a better indication of what failed with the connection.
Pull Request Test Coverage Report for Build 4560544664Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Hey @clydedacruz Thanks for your contribution! Could you please update the changelog? |
@nikoulai Done. I've updated it. |
Ran tests a couple times, |
Fixes. #5954
Existing code gobbles up the real error and only prints a generic message with the URL. This change utilizes the error object to give a better indication of what failed with the connection.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.