Errors not caught in 4.x

packages/web3-eth-contract/test/integration/contract_erc20.test.ts

@@ -49,7 +49,7 @@ describe('contract', () => {
 			};
 		});
 
-		it('should deploy the contract', async () => {
+		it.skip('should deploy the contract', async () => {
 			const acc = await createTempAccount();
 			const sendOptionsLocal = { from: acc.address, gas: '10000000' };
 			await expect(
@@ -120,6 +120,66 @@ describe('contract', () => {
 						value,
 					);
 				});
+
+				it('send tokens from the account that does not have ether', async () => {
+					const tempAccount = await createTempAccount();
+					const test = await createNewAccount({
+						unlock: true,
+						refill: false,
+					});
+
+					let catchError = false;
+					let catchErrorPromise;
+					try {
+						const promiEvent = contractDeployed.methods
+							.transfer(tempAccount.address, '0x1')
+							.send({ ...sendOptions, from: test.address });
+
+						catchErrorPromise = new Promise(resolve => {
+							// eslint-disable-next-line @typescript-eslint/no-floating-promises
+							promiEvent.on('error', err => {
+								// Returned error: insufficient funds for gas * price + value: balance 0, tx cost 25000327300000000, overshot 25000327300000000
+								resolve(err);
+							});
+						});
+						await promiEvent;
+					} catch (e) {
+						// Returned error: insufficient funds for gas * price + value: balance 0, tx cost 25000327300000000, overshot 25000327300000000
+						catchError = true;
+					}
+					expect(await catchErrorPromise).toBeDefined();
+					expect(catchError).toBe(true);
+				});
+				it('send tokens from the account that does not have tokens', async () => {
+					const tempAccount = await createTempAccount();
+					const test = await createNewAccount({
+						unlock: true,
+						refill: true,
+					});
+
+					let catchError = false;
+					let catchErrorPromise;
+					try {
+						const promiEvent = contractDeployed.methods
+							.transfer(tempAccount.address, '0x1')
+							.send({ ...sendOptions, from: test.address });
+
+						catchErrorPromise = new Promise(resolve => {
+							// eslint-disable-next-line @typescript-eslint/no-floating-promises
+							promiEvent.on('error', err => {
+								// Transaction has been reverted by the EVM
+								resolve(err);
+							});
+						});
+						await promiEvent;
+					} catch (e) {
+						// Transaction has been reverted by the EVM
+						catchError = true;
+					}
+					expect(await catchErrorPromise).toBeDefined();
+					expect(catchError).toBe(true);
+				});
+
 				it.each([signAndSendContractMethodEIP1559, signAndSendContractMethodEIP2930])(
 					'should transfer tokens with local wallet %p',
 					async signAndSendContractMethod => {

packages/web3-eth/src/types.ts

@@ -21,6 +21,7 @@ import {
 	TransactionRevertInstructionError,
 	TransactionRevertWithCustomError,
 	InvalidResponseError,
+	TransactionPollingTimeoutError,
 } from 'web3-errors';
 import {
 	FormatType,
@@ -50,6 +51,7 @@ export type SendTransactionEventsBase<ReturnFormat extends DataFormat, TxType> =
 		| TransactionRevertedWithoutReasonError<FormatType<TransactionReceipt, ReturnFormat>>
 		| TransactionRevertInstructionError<FormatType<TransactionReceipt, ReturnFormat>>
 		| TransactionRevertWithCustomError<FormatType<TransactionReceipt, ReturnFormat>>
+		| TransactionPollingTimeoutError
 		| InvalidResponseError
 		| ContractExecutionError;
 };

packages/web3-eth/src/utils/send_tx_helper.ts

@@ -37,6 +37,7 @@
 import {
 	ContractExecutionError,
 	InvalidResponseError,
+	TransactionPollingTimeoutError,
 	TransactionRevertedWithoutReasonError,
 	TransactionRevertInstructionError,
 	TransactionRevertWithCustomError,
@@ -153,7 +154,7 @@
 			!this.options?.ignoreGasPricing &&
 			isNullish((transactionFormatted as Transaction).gasPrice) &&
 			(isNullish((transaction as Transaction).maxPriorityFeePerGas) ||
 				isNullish((transaction as Transaction).maxFeePerGas))
 		) {
 			result = {
 				...transactionFormatted,
@@ -182,8 +183,8 @@
 
 			return trySendTransaction(
 				this.web3Context,
 				async (): Promise<string> =>
 					ethRpcMethods.sendRawTransaction(
 						this.web3Context.requestManager,
 						signedTransaction.rawTransaction,
 					),
@@ -241,9 +242,10 @@
 		if (
 			(_error instanceof InvalidResponseError ||
 				_error instanceof ContractExecutionError ||
 				_error instanceof TransactionRevertWithCustomError ||
 				_error instanceof TransactionRevertedWithoutReasonError ||
-				_error instanceof TransactionRevertInstructionError) &&
+				_error instanceof TransactionRevertInstructionError ||
+				_error instanceof TransactionPollingTimeoutError) &&
 			this.promiEvent.listenerCount('error') > 0
 		) {
 			this.promiEvent.emit('error', _error);

packages/web3-eth/test/integration/web3_eth/send_signed_transaction.test.ts

@@ -33,6 +33,7 @@ import { isHexStrict } from 'web3-validator';
 import { Web3Eth, InternalTransaction, transactionSchema } from '../../../src';
 import {
 	closeOpenConnection,
+	createNewAccount,
 	createTempAccount,
 	getSystemTestBackend,
 	getSystemTestProvider,
@@ -55,6 +56,74 @@ describe('Web3Eth.sendSignedTransaction', () => {
 		await closeOpenConnection(web3Eth);
 	});
 
+	describe('Should catch errors', () => {
+		it('send ether from the account that does not have ether', async () => {
+			let onErrorReceived = false;
+			let catchErrorReceived = false;
+			const from = await createNewAccount({
+				unlock: true,
+				refill: false,
+			});
+			let pr;
+			try {
+				const promiEvent = web3Eth.sendTransaction({
+					to: tempAcc.address,
+					from: from.address,
+				});
+				pr = new Promise(resolve => {
+					// eslint-disable-next-line @typescript-eslint/no-floating-promises
+					promiEvent.on('error', () => {
+						onErrorReceived = true;
+						resolve(true);
+					});
+				});
+				await promiEvent;
+			} catch (e) {
+				catchErrorReceived = true;
+			}
+			await pr;
+			expect(onErrorReceived).toBe(true);
+			expect(catchErrorReceived).toBe(true);
+		});
+		it('send and wait timeout', async () => {
+			let onErrorReceived = false;
+			let catchErrorReceived = false;
+			const from = await createNewAccount({
+				unlock: true,
+				refill: true,
+			});
+
+			web3Eth.setConfig({
+				transactionReceiptPollingInterval: 10,
+				transactionPollingTimeout: 1000,
+			});
+
+			const currentNonce = await web3Eth.getTransactionCount(from.address);
+			let pr;
+			try {
+				const promiEvent = web3Eth.sendTransaction({
+					to: tempAcc.address,
+					from: from.address,
+					value: '0x1',
+					nonce: currentNonce + BigInt(1000),
+				});
+				pr = new Promise(resolve => {
+					// eslint-disable-next-line @typescript-eslint/no-floating-promises
+					promiEvent.on('error', () => {
+						onErrorReceived = true;
+						resolve(true);
+					});
+				});
+				await promiEvent;
+			} catch (e) {
+				catchErrorReceived = true;
+			}
+			await pr;
+			expect(onErrorReceived).toBe(true);
+			expect(catchErrorReceived).toBe(true);
+		});
+	});
+
 	describe('Transaction Types', () => {
 		it('should send a signed simple value transfer - type 0x0', async () => {
 			const temp = await createTempAccount();