Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/4.5.0 #6802

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Release/4.5.0 #6802

merged 4 commits into from
Feb 12, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Feb 8, 2024

[4.5.0]

Added

web3-utils

web3-types

Changed

web3

  • Dependencies updated

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Feb 8, 2024

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 0 618 KB 618 KB -
View detailed bundle breakdown

Added

Asset Old size New size Diff Diff %
web3.min.js 0 601 KB 601 KB -
../lib/commonjs/index.d.ts 0 8.63 KB 8.63 KB -
../lib/commonjs/accounts.d.ts 0 3.89 KB 3.89 KB -
../lib/commonjs/types.d.ts 0 2.45 KB 2.45 KB -
../lib/commonjs/web3.d.ts 0 1.14 KB 1.14 KB -
../lib/commonjs/abi.d.ts 0 999 bytes 999 bytes -
../lib/commonjs/eth.exports.d.ts 0 280 bytes 280 bytes -
../lib/commonjs/providers.exports.d.ts 0 148 bytes 148 bytes -
../lib/commonjs/version.d.ts 0 60 bytes 60 bytes -

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

Copy link

github-actions bot commented Feb 8, 2024

Benchmark

Benchmark suite Current: 2e88e93 Previous: 6c075db Ratio
processingTx 9397 ops/sec (±4.00%) 9301 ops/sec (±4.81%) 0.99
processingContractDeploy 42482 ops/sec (±6.71%) 39129 ops/sec (±7.62%) 0.92
processingContractMethodSend 19951 ops/sec (±6.06%) 19443 ops/sec (±5.19%) 0.97
processingContractMethodCall 40238 ops/sec (±5.18%) 38971 ops/sec (±6.34%) 0.97
abiEncode 46223 ops/sec (±6.85%) 44252 ops/sec (±6.92%) 0.96
abiDecode 31972 ops/sec (±7.37%) 30419 ops/sec (±8.89%) 0.95
sign 1670 ops/sec (±0.72%) 1656 ops/sec (±4.08%) 0.99
verify 368 ops/sec (±2.79%) 373 ops/sec (±0.78%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@luu-alex luu-alex marked this pull request as ready for review February 8, 2024 22:12
@luu-alex luu-alex changed the title update changelog and package.json for release release/4.5.0 Feb 8, 2024
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of tests in CI are not passing

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus PR desc should have only release notes. Thanks Alex

@jdevcs jdevcs added 4.x 4.0 related Release labels Feb 9, 2024
@jdevcs jdevcs changed the title release/4.5.0 Release/4.5.0 Feb 9, 2024
@luu-alex
Copy link
Contributor Author

luu-alex commented Feb 9, 2024

@jdevcs the unit tests will be fixed by #6794 and the other failing testcase on sepolia is an issue occuring from past releases.

@luu-alex luu-alex merged commit 9d65c38 into 4.x Feb 12, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants