Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] fix broken link in README to point to correct address (Issue 6817) #6818

Merged

Conversation

0xthorazine
Copy link
Contributor

Description

Link in README should point to https://docs.web3js.org/guides/advanced/tree_shaking/ but currently points to https://docs.web3js.org/guides/advanced/web3_tree_shaking_support_guide/

Type of change

Fixed link to correct address

@SantiagoDevRel
Copy link
Member

Issue #6817

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xthorazine

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #6818 (c5f0319) into 4.x (4358140) will increase coverage by 4.65%.
Report is 180 commits behind head on 4.x.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6818      +/-   ##
==========================================
+ Coverage   87.37%   92.02%   +4.65%     
==========================================
  Files         197      214      +17     
  Lines        7548     8179     +631     
  Branches     2059     2201     +142     
==========================================
+ Hits         6595     7527     +932     
+ Misses        953      652     -301     
Flag Coverage Δ
UnitTests 92.02% <ø> (+4.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@SantiagoDevRel SantiagoDevRel merged commit 95807a6 into web3:4.x Feb 19, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants