Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research #6841

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Research #6841

merged 8 commits into from
Mar 5, 2024

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Feb 28, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Feb 28, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 621.63 kB → 621.65 kB (+18 B) +0.00%
Changeset
File Δ Size
../web3-utils/lib/commonjs/objects.js 📈 +19 B (+0.83%) 2.25 kB → 2.27 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 603.05 kB → 603.07 kB (+18 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.63 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.26 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/web3_eip6963.d.ts 922 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 148 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Merging #6841 (29982fa) into 4.x (4358140) will increase coverage by 4.68%.
Report is 190 commits behind head on 4.x.
The diff coverage is 100.00%.

❗ Current head 29982fa differs from pull request most recent head 04da750. Consider uploading reports for the commit 04da750 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6841      +/-   ##
==========================================
+ Coverage   87.37%   92.06%   +4.68%     
==========================================
  Files         197      215      +18     
  Lines        7548     8212     +664     
  Branches     2059     2210     +151     
==========================================
+ Hits         6595     7560     +965     
+ Misses        953      652     -301     
Flag Coverage Δ
UnitTests 92.06% <100.00%> (+4.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link

github-actions bot commented Mar 5, 2024

Benchmark

Benchmark suite Current: 04da750 Previous: 6c075db Ratio
processingTx 9587 ops/sec (±4.02%) 9301 ops/sec (±4.81%) 0.97
processingContractDeploy 42958 ops/sec (±7.11%) 39129 ops/sec (±7.62%) 0.91
processingContractMethodSend 20009 ops/sec (±6.89%) 19443 ops/sec (±5.19%) 0.97
processingContractMethodCall 39977 ops/sec (±5.94%) 38971 ops/sec (±6.34%) 0.97
abiEncode 44934 ops/sec (±6.85%) 44252 ops/sec (±6.92%) 0.98
abiDecode 30999 ops/sec (±8.17%) 30419 ops/sec (±8.89%) 0.98
sign 1628 ops/sec (±2.88%) 1656 ops/sec (±4.08%) 1.02
verify 374 ops/sec (±0.49%) 373 ops/sec (±0.78%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants