-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP6963 web3 provider update event #6855
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6855 +/- ##
=======================================
Coverage 92.06% 92.07%
=======================================
Files 215 215
Lines 8212 8222 +10
Branches 2208 2209 +1
=======================================
+ Hits 7560 7570 +10
Misses 652 652
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Related with: #6201
#6859
now
requestEIP6963Providers
return promise resolving toMap<string, EIP6963ProviderDetail>
containing providers list, and it will emitweb3:providersMapUpdated
event for any update to above map objType of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.