-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type checking to unit tests #7027
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 540ff6d | Previous: 88b7e2e | Ratio |
---|---|---|---|
processingTx |
8712 ops/sec (±4.38% ) |
9219 ops/sec (±3.36% ) |
1.06 |
processingContractDeploy |
36662 ops/sec (±7.30% ) |
38213 ops/sec (±7.03% ) |
1.04 |
processingContractMethodSend |
17768 ops/sec (±6.77% ) |
19245 ops/sec (±6.02% ) |
1.08 |
processingContractMethodCall |
37636 ops/sec (±4.10% ) |
38559 ops/sec (±4.51% ) |
1.02 |
abiEncode |
39323 ops/sec (±7.49% ) |
41839 ops/sec (±8.41% ) |
1.06 |
abiDecode |
26979 ops/sec (±8.39% ) |
30277 ops/sec (±6.54% ) |
1.12 |
sign |
1579 ops/sec (±3.39% ) |
1556 ops/sec (±3.30% ) |
0.99 |
verify |
363 ops/sec (±0.64% ) |
374 ops/sec (±0.46% ) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7027 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 215 215
Lines 8289 8289
Branches 2277 2277
=======================================
Hits 7624 7624
Misses 665 665
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.