-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6992 getText update and getName fix #7047
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 8f645ae | Previous: 692987a | Ratio |
---|---|---|---|
processingTx |
9432 ops/sec (±3.65% ) |
8880 ops/sec (±3.76% ) |
0.94 |
processingContractDeploy |
39880 ops/sec (±10.08% ) |
38813 ops/sec (±6.13% ) |
0.97 |
processingContractMethodSend |
20539 ops/sec (±4.46% ) |
18943 ops/sec (±7.10% ) |
0.92 |
processingContractMethodCall |
40979 ops/sec (±5.92% ) |
38006 ops/sec (±5.78% ) |
0.93 |
abiEncode |
44981 ops/sec (±7.83% ) |
43737 ops/sec (±6.49% ) |
0.97 |
abiDecode |
30812 ops/sec (±7.79% ) |
29525 ops/sec (±8.05% ) |
0.96 |
sign |
1648 ops/sec (±0.66% ) |
1523 ops/sec (±3.37% ) |
0.92 |
verify |
378 ops/sec (±0.43% ) |
371 ops/sec (±0.54% ) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
a mainnet test looking up these functions would be great |
I tested some mainnet lookups locally, in some next PR after Infura rate limit fix we can add that. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7047 +/- ##
==========================================
- Coverage 92.21% 92.20% -0.02%
==========================================
Files 215 215
Lines 8329 8334 +5
Branches 2296 2300 +4
==========================================
+ Hits 7681 7684 +3
- Misses 648 650 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
#6992
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.