-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): mastering providers #7070
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
2050a2c
to
4712382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: eac41c9 | Previous: b63af9f | Ratio |
---|---|---|---|
processingTx |
8847 ops/sec (±4.34% ) |
8492 ops/sec (±5.07% ) |
0.96 |
processingContractDeploy |
40102 ops/sec (±6.18% ) |
39518 ops/sec (±6.31% ) |
0.99 |
processingContractMethodSend |
19153 ops/sec (±8.25% ) |
18741 ops/sec (±7.77% ) |
0.98 |
processingContractMethodCall |
39816 ops/sec (±6.13% ) |
39031 ops/sec (±6.06% ) |
0.98 |
abiEncode |
43558 ops/sec (±7.32% ) |
43800 ops/sec (±6.74% ) |
1.01 |
abiDecode |
30143 ops/sec (±7.61% ) |
29194 ops/sec (±8.15% ) |
0.97 |
sign |
1535 ops/sec (±3.45% ) |
1549 ops/sec (±0.87% ) |
1.01 |
verify |
374 ops/sec (±0.48% ) |
368 ops/sec (±0.60% ) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
4712382
to
f8bceb2
Compare
f8bceb2
to
5fcb80e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7070 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 215 215
Lines 8335 8335
Branches 2301 2301
=======================================
Hits 7683 7683
Misses 652 652
Flags with carried forward coverage won't be shown. Click here to find out more.
|
``` ts title='Initialize WS Provider' | ||
import { Web3, WebSocketProvider } from 'web3'; | ||
|
||
//supply a WebSocket provider as a URL string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//supply a WebSocket provider as a URL string | |
// supply a WebSocket provider as a URL string |
nitpick: comments should always have a space before the text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I completely agree 💯 That doesn't seem to be the case in most of the existing docs, though, so I chose to stay consistent. My next PR will be various formatting nitpicks like that 👍🏻
Improvements to Mastering Provider section