-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): header-nav #7082
fix(docs): header-nav #7082
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 56f914a | Previous: 8f62749 | Ratio |
---|---|---|---|
processingTx |
9288 ops/sec (±3.82% ) |
8813 ops/sec (±4.63% ) |
0.95 |
processingContractDeploy |
37489 ops/sec (±6.57% ) |
35202 ops/sec (±8.08% ) |
0.94 |
processingContractMethodSend |
19632 ops/sec (±7.09% ) |
17884 ops/sec (±5.35% ) |
0.91 |
processingContractMethodCall |
39959 ops/sec (±5.47% ) |
34262 ops/sec (±7.43% ) |
0.86 |
abiEncode |
44332 ops/sec (±7.33% ) |
38844 ops/sec (±8.37% ) |
0.88 |
abiDecode |
30639 ops/sec (±7.42% ) |
26526 ops/sec (±8.50% ) |
0.87 |
sign |
1556 ops/sec (±1.06% ) |
1546 ops/sec (±0.88% ) |
0.99 |
verify |
354 ops/sec (±2.42% ) |
353 ops/sec (±0.78% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7082 +/- ##
==========================================
+ Coverage 87.37% 93.98% +6.61%
==========================================
Files 197 215 +18
Lines 7548 8335 +787
Branches 2059 2301 +242
==========================================
+ Hits 6595 7834 +1239
+ Misses 953 501 -452
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I'm not convinced that this is "better" but it addresses some of the topics that were brought up in a meeting today with @mconnelly8 @jdevcs and @SantiagoDevRel