Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): header-nav #7082

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix(docs): header-nav #7082

merged 1 commit into from
Jun 5, 2024

Conversation

danforbes
Copy link
Contributor

I'm not convinced that this is "better" but it addresses some of the topics that were brought up in a meeting today with @mconnelly8 @jdevcs and @SantiagoDevRel

  • The landing page is still "Introduction", this is also where the logo and "Web3.js Docs" link in the header point
  • There is NO highlighted section in the header navbar when the active page is the landing page ("Introduction")
  • "Guides and Tutorials" in the header nav now links to the "Quickstart" page
  • "Guides and Tutorials" is only highlighted when the active page actually falls under "Guides and Tutorials" (with the exception of "Guides and Tutorials" > "Getting Started" > "Introduction")

Copy link

github-actions bot commented Jun 3, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 630.32 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 611.03 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 56f914a Previous: 8f62749 Ratio
processingTx 9288 ops/sec (±3.82%) 8813 ops/sec (±4.63%) 0.95
processingContractDeploy 37489 ops/sec (±6.57%) 35202 ops/sec (±8.08%) 0.94
processingContractMethodSend 19632 ops/sec (±7.09%) 17884 ops/sec (±5.35%) 0.91
processingContractMethodCall 39959 ops/sec (±5.47%) 34262 ops/sec (±7.43%) 0.86
abiEncode 44332 ops/sec (±7.33%) 38844 ops/sec (±8.37%) 0.88
abiDecode 30639 ops/sec (±7.42%) 26526 ops/sec (±8.50%) 0.87
sign 1556 ops/sec (±1.06%) 1546 ops/sec (±0.88%) 0.99
verify 354 ops/sec (±2.42%) 353 ops/sec (±0.78%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.98%. Comparing base (4358140) to head (56f914a).
Report is 259 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7082      +/-   ##
==========================================
+ Coverage   87.37%   93.98%   +6.61%     
==========================================
  Files         197      215      +18     
  Lines        7548     8335     +787     
  Branches     2059     2301     +242     
==========================================
+ Hits         6595     7834    +1239     
+ Misses        953      501     -452     
Flag Coverage Δ
UnitTests 93.98% <ø> (+6.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@jdevcs
Copy link
Contributor

jdevcs commented Jun 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants