-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): introduction #7083
fix(docs): introduction #7083
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: e4ba0aa | Previous: 94f4f82 | Ratio |
---|---|---|---|
processingTx |
9242 ops/sec (±3.70% ) |
8833 ops/sec (±4.02% ) |
0.96 |
processingContractDeploy |
39996 ops/sec (±7.54% ) |
35881 ops/sec (±7.95% ) |
0.90 |
processingContractMethodSend |
19685 ops/sec (±7.97% ) |
18484 ops/sec (±4.82% ) |
0.94 |
processingContractMethodCall |
38139 ops/sec (±6.07% ) |
37028 ops/sec (±4.19% ) |
0.97 |
abiEncode |
44613 ops/sec (±6.34% ) |
39527 ops/sec (±7.28% ) |
0.89 |
abiDecode |
29505 ops/sec (±8.62% ) |
27646 ops/sec (±8.72% ) |
0.94 |
sign |
1558 ops/sec (±2.93% ) |
1571 ops/sec (±0.91% ) |
1.01 |
verify |
369 ops/sec (±0.90% ) |
360 ops/sec (±2.83% ) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7083 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 215 215
Lines 8335 8335
Branches 2301 2301
=======================================
Hits 7834 7834
Misses 501 501
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
||
- [zkSync Plugin](https://www.npmjs.com/package/web3-plugin-zksync) | ||
|
||
## Features of Web3.js v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep this overview under introduction section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but at same time if we want to highlight "Using These Docs" section , what do you think about using https://docusaurus.io/docs/markdown-features/admonitions ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I just moved the section back to its original location 😅 Are you suggesting that "Features of Web3.js v4" get moved back to its original location and then we use an admonition for the "Using These Docs" section? I do not necessarily like the idea of using an admonition for "Using These Docs" as I think it's too much text to go into an admonition...
6077e2e
to
393b145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just added few updates ideas, Thanks @danforbes
Description